Killaura and maceDMG incompatibility

Arti

Hello!
I found another bug with Killaura and MaceDMG—they just don't work together.

When I have MaceDMG on with Killaura, Killaura doesn't activate/use MaceDMG (from the ground).

However, MaceDMG works when hitting manually.

Additionally: why do you use (in the MaceDmgHack.java)
sendFakeY(Math.sqrt(500));

why not just using a higher number so the damage increases?

I'm am not very familiar with possible Minecraft anti measures so I don't understand why you root and only use 22 blocks?

(I am suspecting that you use 22 bc it is the height a player would still survive withou armor)
Can we turn up this value or will this break something?

I am very impressed by your creativity and simplicity at the same time in coding the MaceDMG!

JAXPLE

Arti

@Override

public void onHandleInput()

{

	if(target == null)

		return;

	

	WURST.getHax().criticalsHack.doCritical();

	MC.interactionManager.attackEntity(MC.player, target);

	swingHand.swing(Hand.MAIN_HAND);

	

	target = null;

	speed.resetTimer(speedRandMS.getValue());

}

This code is the code section responsible for the attack on KillAura

MC.interactionManager.attackEntity(MC.player, target);

The code I just presented in the code above is the part that attacks the user, and you can see that there is no part that sets up the Mace attack fakeY Packet

To apply it as you said, I think we need to declare one boolean variable and code the fake packet code in the attack-related module, but I expect the work to be pushed back from the priority

The critical code is in a similar context

WURST.getHax().criticalsHack.doCritical();

Alexander01998

Hey Arti!

Thanks for pointing out that bug with Killaura and MaceDMG not working together. I'll make sure this is fixed in the next update.

Regarding the sendFakeY(Math.sqrt(500)); line, there is a comment in the code that explains why it's set up this way:

// See ServerPlayNetworkHandler.onPlayerMove()
// for why it's using these numbers.
// Also, let me know if you find a way to bypass that check in 1.21.
for(int i = 0; i < 4; i++)
sendFakeY(0);
sendFakeY(Math.sqrt(500));
sendFakeY(0);

If you look at the code in ServerPlayNetworkHandler.onPlayerMove(), you can see why the sqrt(500) is needed (I've added some comments to highlight the important parts):

// ...
double o = this.player.getVelocity().lengthSquared(); // <-- it's important that this is a squared value
double p = l * l + m * m + n * n;
if (this.player.isSleeping()) {
	// ...
} else {
	boolean bl = this.player.isFallFlying();
	if (serverWorld.getTickManager().shouldTick()) {
		this.movePacketsCount++;
		int q = this.movePacketsCount - this.lastTickMovePacketsCount;
		if (q > 5) { // <-- up to 5 packets in one tick are allowed here
			LOGGER.debug("{} is sending move packets too frequently ({} packets since last tick)", this.player.getName().getString(), q);
			q = 1;
		}

		if (!this.player.isInTeleportationState() && (!this.player.getWorld().getGameRules().getBoolean(GameRules.DISABLE_ELYTRA_MOVEMENT_CHECK) || !bl)) {
			float r = bl ? 300.0F : 100.0F; // <-- up to 100 per packet are allowed without elytra
			if (p - o > (double)(r * (float)q) && !this.isHost()) { // <-- it's comparing against the squared velocity, so instead of 500 we can only do sqrt(500)
				LOGGER.warn("{} moved too quickly! {},{},{}", this.player.getName().getString(), l, m, n);
				this.requestTeleport(this.player.getX(), this.player.getY(), this.player.getZ(), this.player.getYaw(), this.player.getPitch());
				return;
			}
		}
	}
	// ...
}
// ...

So, basically Math.sqrt(500) is the highest value we can use without the server rejecting it and taking away almost all of the damage bonus.

Hope that clears it up!

Update: This bug has been fixed in Wurst 7.45.

Superwheat

this now sometimes works and sometimes doesn't, also can't this be fixed for multi aura too?

Arti

Superwheat Yea I had the same feeling too that it doesn't work every time 😭

Superwheat

Arti and with manual click it works all the time unless you're spamming it like attacking 3 entities in a second

Superwheat

Superwheat yet it still works a little bit cause you can hear the mace doing its thing