MaceDMG

Cloudscoollol

Hey I would think it would be really cool if you allow a slider or just increase the damage that the mace deals using the module MaceDMG because I think you mentioned that it's equivalent to 22 blocks It would be really cool if you could increase that or implement a slider which would allow it to go to a max of 100 blocks?

TwystedXYZ

The current MaceDMG module is enough to kill any player you might run across, even in full netherite armor.

Cloudscoollol

TwystedXYZ wardens? (Last time I checked it couldn't)

TwystedXYZ

hm, that's a very fair point. i'll see if i can modify the source code to jack up the damage output.

TwystedXYZ

@Alexander01998 Would you be averse to me filing a pull request after I test the change I made? (I added one zero to Math.sqrt(500), so from my understanding it should now simulate a 70 block fall instead of a 22 block fall.)

Alexander01998

Hey TwystedXYZ,

Last time I checked, anything above sqrt(500) doesn't work at all due to a check in the vanilla Minecraft server code that completely blocks the packet if the distance is higher. I left a comment on that code linking to where that check is in the Minecraft source code. I've also explained in a bit more detail in this WurstForum post.

So unless something has changed an that check doesn't exist anymore, I don't think adding an extra zero there would be a good idea as it would just prevent MaceDMG from working.

TwystedXYZ

I see. I was unaware of this packet limit, thanks for notifying me.

Cloudscoollol

So this isn't possible? (Btw is this limit present in fabric, forge and neoforge servers aswell?)

Alexander01998

Cloudscoollol As far as I know, all servers have this limit as of 1.21. In older Minecraft versions it was possible to go much higher, but that was when the mace didn't exist yet.

Cloudscoollol

Alexander01998 do you think it is possible to make the module function as a variable like make the simulating 22 blocks the base which increases as you fall

For eg falling 4 blocks and hitting a target will be equal to 26 blocks of damage instead of 4 with maceDMG on?