Misimplemented NBT commands

ZANXEY

Wurst version > 7.41.1
Minecraft version >= 24w09a (1.20.5)

Prior to the 24w09a update, NBT commands (e.g. ViewNbtCmd) could interact with all NBT data.
Following changes to the NBT system introduced in 24w09a, an update commit was made, that restricted the scope to just CUSTOM_DATA, effectively rendering these commands mostly useless.

Alexander01998

Hey ZANXEY, yes, I am aware of this.

CUSTOM_DATA actually is the NBT data component, and since the way components work is quite different from NBT, I'm not sure calling components NBT data is accurate. However, it's true that these commands aren't nearly as useful as they used to be, since the most useful item data is now stored in components instead of NBT.

I think ideally .modify should be changed to edit the component map and a .viewcomp command should be added to read the component map (instead of changing .viewnbt to read components - that doesn't seem right).

ZANXEY

I see.

I think the best (or at least the most straightforward) way to implement .viewcomp would be this (based on .viewnbt):

public final class ViewComp extends Command
{
	public ViewComp()
	{
		super("viewcomp", "Shows you components of the held item.", ".viewcomp",
			"Copy to clipboard: .viewcomp copy");
	}
	
	@Override
	public void call(String[] args) throws CmdException
	{
		ClientPlayerEntity player = MC.player;
		ItemStack stack = player.getInventory().getMainHandStack();
		if(stack.isEmpty())
			throw new CmdError("You must hold an item in your main hand.");
		
		NbtElement components = ComponentChanges.CODEC
			.encodeStart(player.getRegistryManager().getOps(NbtOps.INSTANCE),
				stack.getComponentChanges())
			.getOrThrow();
		String compString = components.asString();
		
		switch(String.join(" ", args).toLowerCase())
		{
			case "":
			ChatUtils.message("Components: " + compString);
			break;
			
			case "copy":
			MC.keyboard.setClipboard(compString);
			ChatUtils.message("Components copied to clipboard.");
			break;
			
			default:
			throw new CmdSyntaxError();
		}
	}
}

.modify on the other hand, mostly needs to be rewritten from scratch ig